Stop race condition on cloud event YAML test #1517
Conversation
If the sink service is started after the cloud event fails, the cloud event will never be delivered. Ensure the sink is running before completing the task that sends the cloud event.
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
| image: python:3-alpine | ||
| imagePullPolicy: IfNotPresent | ||
| command: ["/bin/sh"] | ||
| args: |
There was a problem hiding this comment.
Do we want to use script: here? Or maybe wait until it's actually released in 0.9?
There was a problem hiding this comment.
I can prepare the PR, we can decide to merge it later, but it would be good to have updated examples when 0.9 goes out.
| @@ -75,6 +74,30 @@ spec: | |||
| - name: notification | |||
| type: cloudEvent | |||
| steps: | |||
| - name: wait-for-sink | |||
| image: python:3-alpine | |||
| imagePullPolicy: IfNotPresent | |||
There was a problem hiding this comment.
This is the default, so I think we can just omit it for brevity.
If the sink service is started after the cloud event fails, the
cloud event will never be delivered.
Ensure the sink is running before completing the task that sends
the cloud event.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes